Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reference to contribsys values #255

Merged
merged 1 commit into from Mar 25, 2024
Merged

fix reference to contribsys values #255

merged 1 commit into from Mar 25, 2024

Conversation

peetucket
Copy link
Member

Why was this change made?

I think there is a statement in the README that is now false. Made it true.

@@ -18,7 +18,7 @@ Make sure that:
* You have previously `ssh`-ed into all servers.
* NOTE: If you are unsure about this, run `bin/sdr check_ssh -e [qa|stage|prod]` and watch the output for any errors!
* NOTE: if you run `bin/sdr check_cocina`, you may need to ensure that you have the contribsys gem credentials available for google-books to install the sidekiq-pro gem locally (the credential is already on our deploy target VMs).
* You can get the env variable name and value from the README in shared_configs for google-books-prod (not in google-books-stage or -qa)
* The credentials are set via puppet from values stored in vault.
* NOTE: You *may* invoke the `bin/` scripts via `bundle exec`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't track down where it is in vault though (or I don't have permissions to see it)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like i don't have permission either, but the various vault paths to try are explained here (i always have to refer back to this since i use vault infrequently enough to forget between uses): https://consul.stanford.edu/display/systeam/Vault+for+Developers

might link that doc?

alternatively, you could suggest something more circuitous: look in puppet for the env var name for a VM that uses that value, ssh to the VM, ksu or ssh to the app user account, print the env var value, and then use that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestions...updated readme

@@ -18,7 +18,7 @@ Make sure that:
* You have previously `ssh`-ed into all servers.
* NOTE: If you are unsure about this, run `bin/sdr check_ssh -e [qa|stage|prod]` and watch the output for any errors!
* NOTE: if you run `bin/sdr check_cocina`, you may need to ensure that you have the contribsys gem credentials available for google-books to install the sidekiq-pro gem locally (the credential is already on our deploy target VMs).
* You can get the env variable name and value from the README in shared_configs for google-books-prod (not in google-books-stage or -qa)
* The credentials are set via puppet from values stored in vault.
* NOTE: You *may* invoke the `bin/` scripts via `bundle exec`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like i don't have permission either, but the various vault paths to try are explained here (i always have to refer back to this since i use vault infrequently enough to forget between uses): https://consul.stanford.edu/display/systeam/Vault+for+Developers

might link that doc?

alternatively, you could suggest something more circuitous: look in puppet for the env var name for a VM that uses that value, ssh to the VM, ksu or ssh to the app user account, print the env var value, and then use that.

@peetucket peetucket merged commit 30c88eb into main Mar 25, 2024
2 checks passed
@peetucket peetucket deleted the update-readme-2 branch March 25, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants