Improving HEK Representation #7619
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
May 13, 2024
|
You will need to add regions to https://github.com/sunpy/sunpy/blob/main/pyproject.toml#L77 so it is installed. |
nabobalis
reviewed
May 13, 2024
nabobalis
reviewed
May 13, 2024
nabobalis
reviewed
May 13, 2024
nabobalis
reviewed
May 19, 2024
nabobalis
reviewed
May 19, 2024
nabobalis
reviewed
May 19, 2024
nabobalis
reviewed
May 19, 2024
nabobalis
reviewed
May 19, 2024
nabobalis
reviewed
May 30, 2024
nabobalis
reviewed
May 30, 2024
nabobalis
reviewed
May 31, 2024
Comment on lines
+15
to
+16
| UNIT_FILE_PATH = Path(os.path.dirname(__file__)) / "unit_properties.json" | ||
| COORD_FILE_PATH = Path(os.path.dirname(__file__)) / "coord_properties.json" |
There was a problem hiding this comment.
I think these can be added to the all and imported else where as required.
nabobalis
reviewed
May 31, 2024
sunpy/net/hek/utils.py
Outdated
| COORD_FILE_PATH = Path(os.path.dirname(__file__)) / "coord_properties.json" | ||
|
|
||
| def freeze(obj): | ||
| """ Create hashable representation of result dict. """ |
There was a problem hiding this comment.
Suggested change
| """ Create hashable representation of result dict. """ | |
| """ | |
| Create a hashable representation of a dict or list. | |
| Otherwise returns the original input. | |
| """ |
There was a problem hiding this comment.
I take issue with the function name but that's a separate conversation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the work that has been done in GSoC 23 but in a new and fresh branch to start GSoC 24.
I've migrated GSoC 23 commits and resolved most of the conflicts, it needs a review to see if there is any conflict remaining.