Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed .norm in GenericMap to .mpl_color_normalizer #877

Merged
merged 6 commits into from
Mar 3, 2014

Conversation

mdmueller
Copy link
Contributor

As addressed in issue #860.

@derdon
Copy link
Member

derdon commented Mar 1, 2014

I think the documentation for the attribute is not visible in the Sphinx docs. Can you check this?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9df44b6 on amras1:rename-norm into ee1d14f on sunpy:master.

@@ -160,13 +160,13 @@ def get_colors(self, index=None):
return self._maps[index].cmap

def get_norm(self, index=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be get_mpl_color_normalizer

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8e384fb on amras1:rename-norm into ee1d14f on sunpy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 90569e3 on amras1:rename-norm into ee1d14f on sunpy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 90569e3 on amras1:rename-norm into ee1d14f on sunpy:master.

Cadair added a commit that referenced this pull request Mar 3, 2014
Renamed .norm in GenericMap to .mpl_color_normalizer
@Cadair Cadair merged commit aac53ef into sunpy:master Mar 3, 2014
@mdmueller mdmueller deleted the rename-norm branch March 3, 2014 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants