New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count of member states should be more reliable? #163

Closed

jeromegn wants to merge 1 commit into main from fix-members-overflow

Member

jeromegn commented Mar 1, 2024

Somehow this could overflow a Vec capacity. The SocketAddr has size of 32, so it would have to be pretty enormous to fail, this is confusing.

If I understand correctly, a Vec can hold up to isize::MAX bytes. isize::MAX / 32 is enormous...


          count of member states should be more reliable?

b2b8901

jeromegn requested a review from spacekookie

March 1, 2024 15:16

Member Author

jeromegn commented Mar 5, 2024

This has been merged as part of #164

jeromegn closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment