Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added touch controls. #41

Merged
merged 11 commits into from Jul 30, 2018
Merged

Added touch controls. #41

merged 11 commits into from Jul 30, 2018

Conversation

NicholeMattera
Copy link
Contributor

No description provided.

@yellows8
Copy link
Collaborator

Can the touch memallocs be removed, and use bool flags instead?

@yellows8
Copy link
Collaborator

Guess we'd need new touch icons for "Back" and Y-button (netloader-enable) - doesn't need done in this PR.

@CTCaer
Copy link

CTCaer commented May 30, 2018

If the problem is the size of the icons/text,
a simple transparent image, to the size of button icon + text, and making that respond to touch will suffice. In other words touch event rectangles.

@yellows8
Copy link
Collaborator

It's still rather small / close to the app-icons though.

@CTCaer
Copy link

CTCaer commented May 30, 2018

Size is consistent with the nx menu though :P

I agree that it's close to the app icons though.

@NicholeMattera
Copy link
Contributor Author

NicholeMattera commented May 30, 2018

I removed the mallocs and changed them to be bool flags. I could also make the Back and Open on the bottom easily touchable. Also now that I'm looking down there the Back button is using font size 20 and the open and launch buttons are using 18. Not sure if that is intentional.

@yellows8
Copy link
Collaborator

" I could also make the Back and Open on the bottom easily touchable." Sure, as long as it doesn't interfere with the app-icons-touch.

"Not sure if that is intentional." probably

@NicholeMattera
Copy link
Contributor Author

I've gone ahead and made the bottom button prompts tap-able. (They work for me, but I have small hands.) The coordinates are all hard-coded, which may be an issue with different languages if they are going to move to fit different amount of text. (Ex German) However I've also added swipe gestures. You can swipe up to go up a directory and you can swipe down to go into netloader.

@yellows8
Copy link
Collaborator

yellows8 commented Jun 1, 2018

Can you document touch controls in README?

@NicholeMattera
Copy link
Contributor Author

I added instructions to the README.md. I played around with have GIF demonstrations however seemed like a bit much for the readme file. I left them in the resources folder in case maybe you wanted to create a wiki page on the touch controls.

@yellows8
Copy link
Collaborator

yellows8 commented Jun 1, 2018

Remove the space in "net loader".

@NicholeMattera
Copy link
Contributor Author

Fixed.

@yellows8
Copy link
Collaborator

Remove the GIFs.

@NicholeMattera
Copy link
Contributor Author

Removed.

@WinterMute
Copy link
Collaborator

LGTM.

I think we should add a page to the wiki for this, perhaps at http://switchbrew.org/index.php?title=Homebrew_Menu. Might be better to do a more detailed writeup & use the gifs there.

@yellows8 yellows8 merged commit 00e96fd into switchbrew:master Jul 30, 2018
@yellows8
Copy link
Collaborator

README text was moved to the above new Homebrew_Menu page (with a minor change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants