feat: better handling of killing path separator #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add it behind a parameter like |
XOR-op
force-pushed
the
optimized-kill-path-separator
branch
from
780c55c
to
117c14e
Compare
|
Sorry for the late update since I have a busy month. Now this behavior is controlled by the argument. |
sxyazi
reviewed
Jan 9, 2024
| Self { kind: e.args.first().map(|s| s.as_str()).unwrap_or_default() } | ||
| Self { | ||
| kind: e.args.first().map(|s| s.as_str()).unwrap_or_default(), | ||
| mode: e.named.get("big-word").map_or(KillMode::Default, |_| KillMode::BigWord), |
There was a problem hiding this comment.
Its better to impl the FromStr (also Default) trait for the KillMode to do this.
sxyazi
reviewed
Jan 9, 2024
| spaces + count_characters(input.skip(spaces)) | ||
| let space_or_trailing_slash = match input.clone().next() { | ||
| Some(std::path::MAIN_SEPARATOR) if matches!(mode, KillMode::BigWord) => 1, | ||
| Some(c) if CharKind::new(c) == CharKind::Space => count_spaces(input.clone()), |
There was a problem hiding this comment.
It seems that if CharKind::new(c) == CharKind::Space is unnecessary.
sxyazi
force-pushed
the
main
branch
2 times, most recently
from
85d99ce
to
4d8e276
Compare
sxyazi
force-pushed
the
main
branch
12 times, most recently
from
51ea372
to
2febbee
Compare
|
I'm going to close this because it still needs some work and hasn't seen any activity recently. @XOR-op thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handling of killing trailing path separator.
Example: