[make:auth] Use LogoutRouteLoader for logout route when available #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelanleborgne
changed the title
wouterj
reviewed
Oct 22, 2023
weaverryan
reviewed
Oct 23, 2023
maelanleborgne
force-pushed
the
feature/use-logout-route-loader
branch
from
4616c63
to
9654e97
Compare
maelanleborgne
force-pushed
the
feature/use-logout-route-loader
branch
from
9654e97
to
72784c0
Compare
maelanleborgne
force-pushed
the
feature/use-logout-route-loader
branch
from
72784c0
to
5c0430b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1375
I'm definitely not sure about the whole
class_exists,FeatureSupportTraitand all, but I had to find a way to make this feature version-dependent and test-compatible. I'd be happy to get some feedback about this :)