WIP - [make:reset-password] add remove requests #1470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should add this. Calling the new method would go, for example, in some "update profile" controller where the user can update their email address. After determining that the email did change and flushing, then you'd call the method from reset password before redirecting. But I don't see a use-case for having a user trigger this from the frontend directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is a good idea to just include in the generated template. This feature is something you would implement in other parts of an application (like a user profile page). But, I do think we should advertise the ability to flush requests for a user. Perhaps including this method and commenting out the entire thing? Hmm....