Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:*] use getPayload() instead of accessing request on Request objects #1473

Merged
merged 1 commit into from Mar 6, 2024
Merged

[make:*] use getPayload() instead of accessing request on Request objects #1473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Resources/skeleton/authenticator/LoginFormAuthenticator.tpl.php
View file
Open in desktop
Expand Up @@ -16,15 +16,15 @@ public function __construct(private UrlGeneratorInterface $urlGenerator)

public function authenticate(Request $request): Passport
{
$<?= $username_field_var ?> = $request->request->get('<?= $username_field ?>', '');
$<?= $username_field_var ?> = $request->getPayload()->get('<?= $username_field ?>', '');

$request->getSession()->set(SecurityRequestAttributes::LAST_USERNAME, $<?= $username_field_var ?>);

return new Passport(
new UserBadge($<?= $username_field_var ?>),
new PasswordCredentials($request->request->get('password', '')),
new PasswordCredentials($request->getPayload()->get('password', '')),
[
new CsrfTokenBadge('authenticate', $request->request->get('_csrf_token')),<?= $remember_me_badge ? "
new CsrfTokenBadge('authenticate', $request->getPayload()->get('_csrf_token')),<?= $remember_me_badge ? "
new RememberMeBadge(),\n" : "" ?>
]
);
Expand Down
2 changes: 1 addition & 1 deletion src/Resources/skeleton/crud/controller/Controller.tpl.php
View file
Open in desktop
Expand Up @@ -77,7 +77,7 @@ public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_va
<?= $generator->generateRouteForControllerMethod(sprintf('/{%s}', $entity_identifier), sprintf('%s_delete', $route_name), ['POST']) ?>
public function delete(Request $request, <?= $entity_class_name ?> $<?= $entity_var_singular ?>, EntityManagerInterface $entityManager): Response
{
if ($this->isCsrfTokenValid('delete'.$<?= $entity_var_singular ?>->get<?= ucfirst($entity_identifier) ?>(), $request->request->get('_token'))) {
if ($this->isCsrfTokenValid('delete'.$<?= $entity_var_singular ?>->get<?= ucfirst($entity_identifier) ?>(), $request->getPayload()->get('_token'))) {
$entityManager->remove($<?= $entity_var_singular ?>);
$entityManager->flush();
}
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/make-crud/expected/WithCustomRepository.php
View file
Open in desktop
Expand Up @@ -71,7 +71,7 @@ public function edit(Request $request, SweetFood $sweetFood, EntityManagerInterf
#[Route('/{id}', name: 'app_sweet_food_delete', methods: ['POST'])]
public function delete(Request $request, SweetFood $sweetFood, EntityManagerInterface $entityManager): Response
{
if ($this->isCsrfTokenValid('delete'.$sweetFood->getId(), $request->request->get('_token'))) {
if ($this->isCsrfTokenValid('delete'.$sweetFood->getId(), $request->getPayload()->get('_token'))) {
$entityManager->remove($sweetFood);
$entityManager->flush();
}
Expand Down