Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:auth] use getString() instead of get() #1484

Merged
merged 3 commits into from Mar 20, 2024
Merged

[make:auth] use getString() instead of get() #1484

merged 3 commits into from Mar 20, 2024

Conversation

seb-jean
Copy link
Contributor

Use getString instead of get for request.

seb-jean and others added 2 commits March 19, 2024 07:55
@seb-jean @smnandre
Update src/Resources/skeleton/authenticator/LoginFormAuthenticator.tp…
fe3eb5f 
…l.php

Co-authored-by: Simon André <smn.andre@gmail.com>
@seb-jean @smnandre
Update src/Resources/skeleton/authenticator/LoginFormAuthenticator.tp…
47f3290 
…l.php

Co-authored-by: Simon André <smn.andre@gmail.com>
jrushlow
jrushlow approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seb-jean!

@jrushlow jrushlow changed the title Update LoginFormAuthenticator.tpl.php [make:auth] use getString() instead of get() Mar 20, 2024
@jrushlow
Copy link
Collaborator

ci failures fixed in #1485

@jrushlow jrushlow added Feature New Feature Status: Reviewed Has been reviewed by a maintainer labels Mar 20, 2024
@jrushlow jrushlow merged commit dfe86eb into symfony:main Mar 20, 2024
5 of 6 checks passed
@jrushlow jrushlow mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre left review comments

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seb-jean @jrushlow @smnandre