Skip to content

Commit

Permalink
minor #36078 [Uid] work around slow generation of v4 UUIDs (nicolas-g…
Browse files Browse the repository at this point in the history
…rekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Uid] work around slow generation of v4 UUIDs

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This is more than 4 times faster than `uuid_create()` for v4.
As described in https://jolicode.com/blog/uuid-generation-in-php

Commits
-------

a0e8d24 [Uid] work around slow generation of v4 UUIDs
  • Loading branch information
fabpot committed Mar 15, 2020
2 parents 7dc6da6 + a0e8d24 commit 00aab67
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/Symfony/Component/Uid/UuidV4.php
Expand Up @@ -25,7 +25,12 @@ class UuidV4 extends Uuid
public function __construct(string $uuid = null)
{
if (null === $uuid) {
$this->uuid = uuid_create(static::TYPE);
$uuid = random_bytes(16);
$uuid[6] = $uuid[6] & "\x0F" | "\x4F";
$uuid[8] = $uuid[8] & "\x3F" | "\x80";
$uuid = bin2hex($uuid);

$this->uuid = substr($uuid, 0, 8).'-'.substr($uuid, 8, 4).'-'.substr($uuid, 12, 4).'-'.substr($uuid, 16, 4).'-'.substr($uuid, 20, 12);
} else {
parent::__construct($uuid);
}
Expand Down

0 comments on commit 00aab67

Please sign in to comment.