Skip to content

Commit

Permalink
bug #19508 [Process] Fix AbstractPipes::write() for a situation seen …
Browse files Browse the repository at this point in the history
…on HHVM (at least) (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Process] Fix AbstractPipes::write() for a situation seen on HHVM (at least)

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | composer/composer#5381, composer/composer#5566
| License       | MIT
| Doc PR        | -

Even if I tried with my local hhvm, I can't reproduce the reported issues, yet it looks like some versions of HHVM trigger a notice here.

Commits
-------

2bb2b9b [Process] Fix AbstractPipes::write() for a situation seen on HHVM (at least)
  • Loading branch information
nicolas-grekas committed Aug 3, 2016
2 parents 45dac4b + 2bb2b9b commit 05c9f6c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/Symfony/Component/Process/Pipes/AbstractPipes.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,7 @@ protected function write()
if (null === $this->input && !isset($this->inputBuffer[0])) {
fclose($this->pipes[0]);
unset($this->pipes[0]);
}

if (!$w) {
} elseif (!$w) {
return array($this->pipes[0]);
}
}
Expand Down

0 comments on commit 05c9f6c

Please sign in to comment.