Skip to content

Commit

Permalink
bug #21184 [FrameworkBundle] Remove Response* from classes to compile…
Browse files Browse the repository at this point in the history
… (nicolas-grekas)

This PR was merged into the 3.2 branch.

Discussion
----------

[FrameworkBundle] Remove Response* from classes to compile

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20560, symfony/demo#411, FriendsOfSymfony/FOSHttpCacheBundle#276
| License       | MIT
| Doc PR        | -

When HttpCache is used, Response is loaded first, then the kernel is booted (on cache miss), which triggers the loading of classes.php. Since 3.2 generates a context free classes.php, the Response class is now included there when it was excluded previously. And boom, "Cannot declare class Symfony\Component\HttpFoundation\Response".

Commits
-------

9ab5982 [FrameworkBundle] Remove Response* from classes to compile
  • Loading branch information
fabpot committed Jan 6, 2017
2 parents e13f89b + 9ab5982 commit 0f93fac
Showing 1 changed file with 0 additions and 3 deletions.
Expand Up @@ -206,9 +206,6 @@ public function load(array $configs, ContainerBuilder $container)
'Symfony\\Component\\EventDispatcher\\Event',
'Symfony\\Component\\EventDispatcher\\ContainerAwareEventDispatcher',

'Symfony\\Component\\HttpFoundation\\Response',
'Symfony\\Component\\HttpFoundation\\ResponseHeaderBag',

'Symfony\\Component\\HttpKernel\\EventListener\\ResponseListener',
'Symfony\\Component\\HttpKernel\\EventListener\\RouterListener',
'Symfony\\Component\\HttpKernel\\Bundle\\Bundle',
Expand Down

0 comments on commit 0f93fac

Please sign in to comment.