bug #36069 [DI] skip untyped properties in AutowireRequiredProperties…

…Pass (nicolas-grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- [DI] skip untyped properties in AutowireRequiredPropertiesPass | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 048d092 [DI] skip untyped properties in AutowireRequiredPropertiesPass
symfony · Mar 16, 2020 · 0fb0371 · 0fb0371
2 parents 693cf11 + 048d092
commit 0fb0371
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php
@@ -42,6 +42,9 @@ protected function processValue($value, bool $isRoot = false)
 
         $properties = $value->getProperties();
         foreach ($reflectionClass->getProperties() as $reflectionProperty) {
+            if (!$reflectionProperty->hasType()) {
+                continue;
+            }
             if (false === $doc = $reflectionProperty->getDocComment()) {
                 continue;
             }

diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_74.php
@@ -9,6 +9,11 @@ class PropertiesInjection
      */
     public Bar $plop;
 
+    /**
+     * @required
+     */
+    public $plip;
+
     public function __construct(A $a)
     {
     }