[Form] Form::isBound() and Form::isValid() work correctly now for rea…

…d-only forms
symfony · May 18, 2011 · 13a964a · 13a964a
1 parent 829aa4d
commit 13a964a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Symfony/Component/Form/Form.php b/src/Symfony/Component/Form/Form.php
@@ -452,6 +452,8 @@ public function getExtraData()
     public function bind($clientData)
     {
         if ($this->readOnly) {
+            $this->bound = true;
+
             return $this;
         }
 

diff --git a/tests/Symfony/Tests/Component/Form/FormTest.php b/tests/Symfony/Tests/Component/Form/FormTest.php
@@ -159,6 +159,7 @@ public function testBindIsIgnoredIfReadOnly()
         $form->bind('new');
 
         $this->assertEquals('initial', $form->getData());
+        $this->assertTrue($form->isBound());
     }
 
     public function testNeverRequiredIfParentNotRequired()
@@ -297,6 +298,14 @@ public function testValidIfBound()
         $this->assertTrue($this->form->isValid());
     }
 
+    public function testValidIfBoundAndReadOnly()
+    {
+        $form = $this->getBuilder()->setReadOnly(true)->getForm();
+        $form->bind('foobar');
+
+        $this->assertTrue($form->isValid());
+    }
+
     public function testNotValidIfNotBound()
     {
         $this->assertFalse($this->form->isValid());