Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #23018 [FrameworkBundle] Fix CacheCollectorPass priority (chalasr)
This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Fix CacheCollectorPass priority | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | #22960 (comment) It was run before optimization, so child definitions were not resolved yet. Commits ------- 28b253a Fix CacheCollectorPass priority
- Loading branch information
Showing
4 changed files
with
69 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...fony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/CacheCollectorPassTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\CacheCollectorPass; | ||
use Symfony\Component\Cache\Adapter\FilesystemAdapter; | ||
use Symfony\Component\Cache\Adapter\TagAwareAdapter; | ||
use Symfony\Component\Cache\Adapter\TraceableAdapter; | ||
use Symfony\Component\Cache\Adapter\TraceableTagAwareAdapter; | ||
use Symfony\Component\Cache\DataCollector\CacheDataCollector; | ||
use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
use Symfony\Component\DependencyInjection\Reference; | ||
|
||
class CacheCollectorPassTest extends TestCase | ||
{ | ||
public function testProcess() | ||
{ | ||
$container = new ContainerBuilder(); | ||
$container | ||
->register('fs', FilesystemAdapter::class) | ||
->addTag('cache.pool'); | ||
$container | ||
->register('tagged_fs', TagAwareAdapter::class) | ||
->addArgument(new Reference('fs')) | ||
->addTag('cache.pool'); | ||
|
||
$collector = $container->register('data_collector.cache', CacheDataCollector::class); | ||
(new CacheCollectorPass())->process($container); | ||
|
||
$this->assertEquals(array( | ||
array('addInstance', array('fs', new Reference('fs'))), | ||
array('addInstance', array('tagged_fs', new Reference('tagged_fs'))), | ||
), $collector->getMethodCalls()); | ||
|
||
$this->assertSame(TraceableAdapter::class, $container->findDefinition('fs')->getClass()); | ||
$this->assertSame(TraceableTagAwareAdapter::class, $container->getDefinition('tagged_fs')->getClass()); | ||
$this->assertFalse($collector->isPublic(), 'The "data_collector.cache" should be private after processing'); | ||
} | ||
} |