Improved Cache-Control header when no-cache is sent

symfony · Dec 11, 2012 · 1ab4923 · 1ab4923
1 parent f853fc3
commit 1ab4923
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -245,6 +245,12 @@ public function prepare(Request $request)
             $this->setProtocolVersion('1.1');
         }
 
+        // Check if we need to send extra expire info headers
+        if ('1.0' == $this->getProtocolVersion() && 'no-cache' == $this->headers->get('Cache-Control')) {
+            $this->headers->set('pragma', 'no-cache');
+            $this->headers->set('expires', -1);
+        }
+
         return $this;
     }
 
@@ -686,8 +692,14 @@ public function getMaxAge()
             return $age;
         }
 
-        if (null !== $this->getExpires()) {
-            return $this->getExpires()->format('U') - $this->getDate()->format('U');
+        $expiry = $this->getExpires();
+
+        if (!$expiry instanceof \DateTime && (-1 == $expiry || 0 === $expiry)) {
+            return $expiry;
+        }
+
+        if (null !== $expiry) {
+            return $expiry->format('U') - $this->getDate()->format('U');
         }
 
         return null;