[DomCrawler] Added support for <area> tags to be treated as links

symfony · Feb 11, 2014 · 23acd26 · 23acd26
1 parent a1813cb
commit 23acd26
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/Symfony/Component/DomCrawler/Link.php b/src/Symfony/Component/DomCrawler/Link.php
@@ -12,7 +12,7 @@
 namespace Symfony\Component\DomCrawler;
 
 /**
- * Link represents an HTML link (an HTML a tag).
+ * Link represents an HTML link (an HTML a or area tag).
  *
  * @author Fabien Potencier <fabien@symfony.com>
  *
@@ -188,7 +188,7 @@ protected function canonicalizePath($path)
      */
     protected function setNode(\DOMNode $node)
     {
-        if ('a' != $node->nodeName) {
+        if ('a' != $node->nodeName && 'area' != $node->nodeName) {
             throw new \LogicException(sprintf('Unable to click on a "%s" tag.', $node->nodeName));
         }
 

diff --git a/src/Symfony/Component/DomCrawler/Tests/LinkTest.php b/src/Symfony/Component/DomCrawler/Tests/LinkTest.php
@@ -74,6 +74,18 @@ public function testGetUri($url, $currentUri, $expected)
         $this->assertEquals($expected, $link->getUri());
     }
 
+    /**
+     * @dataProvider getGetUriTests
+     */
+    public function testGetUriOnArea($url, $currentUri, $expected)
+    {
+        $dom = new \DOMDocument();
+        $dom->loadHTML(sprintf('<html><map><area href="%s" /></map></html>', $url));
+        $link = new Link($dom->getElementsByTagName('area')->item(0), $currentUri);
+
+        $this->assertEquals($expected, $link->getUri());
+    }
+
     public function getGetUriTests()
     {
         return array(