Fix issue 9172

symfony · May 4, 2014 · 25f1d85 · 25f1d85
1 parent 8f8b20c
commit 25f1d85
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 1 deletion.
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * Added `translation:debug` command
+ * Added `--no-backup` option to `translation:update` command
  * Added `config:debug` command
  * Added `yaml:lint` command
  * Deprecated the `RouterApacheDumperCommand` which will be removed in Symfony 3.0.

diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -52,6 +52,10 @@ protected function configure()
                     'force', null, InputOption::VALUE_NONE,
                     'Should the update be done'
                 ),
+                new InputOption(
+                    'no-backup', null, InputOption::VALUE_NONE,
+                    'Should backup be disabled'
+                ),
                 new InputOption(
                     'clean', null, InputOption::VALUE_NONE,
                     'Should clean not found messages'
@@ -139,6 +143,10 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         }
 
+        if ($input->getOption('no-backup') === true) {
+            $writer->disableBackup();
+        }
+
         // save the files
         if ($input->getOption('force') === true) {
             $output->writeln('Writing files');

diff --git a/src/Symfony/Component/Translation/CHANGELOG.md b/src/Symfony/Component/Translation/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * added relative file path template to the file dumpers
+ * added optional backup to the file dumpers
  * changed IcuResFileDumper to extend FileDumper
 
 2.3.0

diff --git a/src/Symfony/Component/Translation/Dumper/FileDumper.php b/src/Symfony/Component/Translation/Dumper/FileDumper.php
@@ -31,6 +31,13 @@ abstract class FileDumper implements DumperInterface
      */
     protected $relativePathTemplate = '%domain%.%locale%.%extension%';
 
+    /**
+     * Make file backup before the dump.
+     *
+     * @var bool
+     */
+    private $backup = true;
+
     /**
      * Sets the template for the relative paths to files.
      *
@@ -41,6 +48,16 @@ public function setRelativePathTemplate($relativePathTemplate)
         $this->relativePathTemplate = $relativePathTemplate;
     }
 
+    /**
+     * Sets backup flag.
+     *
+     * @param bool
+     */
+    public function setBackup($backup)
+    {
+        $this->backup = $backup;
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -55,7 +72,9 @@ public function dump(MessageCatalogue $messages, $options = array())
             // backup
             $fullpath = $options['path'].'/'.$this->getRelativePath($domain, $messages->getLocale());
             if (file_exists($fullpath)) {
-                copy($fullpath, $fullpath.'~');
+                if ($this->backup) {
+                    copy($fullpath, $fullpath.'~');
+                }
             } else {
                 $directory = dirname($fullpath);
                 if (!file_exists($directory) && !@mkdir($directory, 0777, true)) {

diff --git a/src/Symfony/Component/Translation/Writer/TranslationWriter.php b/src/Symfony/Component/Translation/Writer/TranslationWriter.php
@@ -39,6 +39,16 @@ public function addDumper($format, DumperInterface $dumper)
         $this->dumpers[$format] = $dumper;
     }
 
+    /**
+     * Disables dumper backup.
+     */
+    public function disableBackup()
+    {
+        foreach ($this->dumpers as $dumper) {
+            $dumper->setBackup(false);
+        }
+    }
+
     /**
      * Obtains the list of supported formats.
      *