convertDomElementToArray should handle zero values

symfony · Mar 13, 2014 · 34720c9 · 34720c9
1 parent e8dadd5
commit 34720c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Symfony/Component/Config/Tests/Util/XmlUtilsTest.php b/src/Symfony/Component/Config/Tests/Util/XmlUtilsTest.php
@@ -80,6 +80,7 @@ public function getDataForConvertDomToArray()
             array(array('foo' => null), '<foo />'),
             array(array('foo' => 'bar'), '<foo>bar</foo>'),
             array(array('foo' => array('foo' => 'bar')), '<foo foo="bar"/>'),
+            array(array('foo' => array('foo' => 0)), '<foo><foo>0</foo></foo>'),
             array(array('foo' => array('foo' => 'bar')), '<foo><foo>bar</foo></foo>'),
             array(array('foo' => array('foo' => 'bar', 'value' => 'text')), '<foo foo="bar">text</foo>'),
             array(array('foo' => array('attr' => 'bar', 'foo' => 'text')), '<foo attr="bar"><foo>text</foo></foo>'),

diff --git a/src/Symfony/Component/Config/Util/XmlUtils.php b/src/Symfony/Component/Config/Util/XmlUtils.php
@@ -132,7 +132,7 @@ public static function convertDomElementToArray(\DomElement $element, $checkPref
         $nodeValue = false;
         foreach ($element->childNodes as $node) {
             if ($node instanceof \DOMText) {
-                if (trim($node->nodeValue)) {
+                if (strlen(trim($node->nodeValue)) > 0) {
                     $nodeValue = trim($node->nodeValue);
                     $empty = false;
                 }