Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #35553 Fix HTTP client config handling (julienfalque)
This PR was merged into the 4.4 branch. Discussion ---------- Fix HTTP client config handling | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Defining a `key` parameter in the `query` option of a scoped HTTP client triggers an error: ``` Undefined index: value ``` This PR fixes this issue but an edge case still remains with YAML and PHP config. If one wants to define parameters `key=foo`, `value=bar` and nothing else, the query will actually be `foo=bar` instead of `key=foo&value=bar`. Not sure how to fix this case without breaking the tests I added here. Commits ------- 963d0cc Fix HTTP client config handling
- Loading branch information
Showing
5 changed files
with
71 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
...ony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/http_client_xml_key.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<?php | ||
|
||
$container->loadFromExtension('framework', [ | ||
'http_client' => [ | ||
'default_options' => [ | ||
'resolve' => [ | ||
'host' => '127.0.0.1', | ||
], | ||
], | ||
'scoped_clients' => [ | ||
'foo' => [ | ||
'base_uri' => 'http://example.com', | ||
'query' => [ | ||
'key' => 'foo', | ||
], | ||
'resolve' => [ | ||
'host' => '127.0.0.1', | ||
], | ||
], | ||
], | ||
], | ||
]); |
19 changes: 19 additions & 0 deletions
19
...ony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/http_client_xml_key.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?xml version="1.0" encoding="utf-8" ?> | ||
<container xmlns="http://symfony.com/schema/dic/services" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xmlns:framework="http://symfony.com/schema/dic/symfony" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd | ||
http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd"> | ||
|
||
<framework:config> | ||
<framework:http-client> | ||
<framework:default-options> | ||
<framework:resolve host="host">127.0.0.1</framework:resolve> | ||
</framework:default-options> | ||
<framework:scoped-client name="foo" base-uri="http://example.com"> | ||
<framework:query key="key">foo</framework:query> | ||
<framework:resolve host="host">127.0.0.1</framework:resolve> | ||
</framework:scoped-client> | ||
</framework:http-client> | ||
</framework:config> | ||
</container> |
12 changes: 12 additions & 0 deletions
12
...ony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/http_client_xml_key.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
framework: | ||
http_client: | ||
default_options: | ||
resolve: | ||
host: 127.0.0.1 | ||
scoped_clients: | ||
foo: | ||
base_uri: http://example.com | ||
query: | ||
key: foo | ||
resolve: | ||
host: 127.0.0.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters