Skip to content

Commit

Permalink
feature #23184 [HttpFoundation] Remove obsolete ini settings for sess…
Browse files Browse the repository at this point in the history
…ions (fabpot)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[HttpFoundation] Remove obsolete ini settings for sessions

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21606
| License       | MIT
| Doc PR        | n/a

As of PHP 7.1, those settings do not exist anymore. See http://php.net/manual/de/migration71.other-changes.php#migration71.other-changes.session-id-generation-without-hashing

Commits
-------

86911b5 [HttpFoundation] removed obsolete ini settings for sessions
  • Loading branch information
fabpot committed Jun 14, 2017
2 parents 9e680f0 + 86911b5 commit 3bbb657
Showing 1 changed file with 3 additions and 6 deletions.
Expand Up @@ -71,13 +71,10 @@ class NativeSessionStorage implements SessionStorageInterface
* cookie_lifetime, "0"
* cookie_path, "/"
* cookie_secure, ""
* entropy_file, ""
* entropy_length, "0"
* gc_divisor, "100"
* gc_maxlifetime, "1440"
* gc_probability, "1"
* hash_bits_per_character, "4"
* hash_function, "0"
* name, "PHPSESSID"
* referer_check, ""
* serialize_handler, "php"
Expand Down Expand Up @@ -328,9 +325,9 @@ public function setOptions(array $options)
$validOptions = array_flip(array(
'cache_limiter', 'cookie_domain', 'cookie_httponly',
'cookie_lifetime', 'cookie_path', 'cookie_secure',
'entropy_file', 'entropy_length', 'gc_divisor',
'gc_maxlifetime', 'gc_probability', 'hash_bits_per_character',
'hash_function', 'name', 'referer_check',
'gc_divisor',
'gc_maxlifetime', 'gc_probability',
'name', 'referer_check',
'serialize_handler', 'use_strict_mode', 'use_cookies',
'use_only_cookies', 'use_trans_sid', 'upload_progress.enabled',
'upload_progress.cleanup', 'upload_progress.prefix', 'upload_progress.name',
Expand Down

0 comments on commit 3bbb657

Please sign in to comment.