[Serializer] fixed XmlEncoder for single char tags

symfony · Mar 12, 2011 · 411a382 · 411a382
1 parent f6c119c
commit 411a382
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php b/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
@@ -296,6 +296,6 @@ protected function isElementNameValid($name)
     {
         return $name &&
             false === strpos($name, ' ') &&
-            preg_match('#^[\pL_][\pL0-9._-]+$#ui', $name);
+            preg_match('#^[\pL_][\pL0-9._-]*$#ui', $name);
     }
 }
diff --git a/tests/Symfony/Tests/Component/Serializer/Encoder/XmlEncoderTest.php b/tests/Symfony/Tests/Component/Serializer/Encoder/XmlEncoderTest.php
@@ -66,7 +66,8 @@ public function testAttributes()
                 '@Type' => 'test'
             ),
             'föo_bär' => '',
-            "Bar" => array(1,2,3)
+            "Bar" => array(1,2,3),
+            'a' => 'b',
         );
         $expected = '<?xml version="1.0"?>'."\n".
             '<response>'.
@@ -76,6 +77,7 @@ public function testAttributes()
             '<Bar>1</Bar>'.
             '<Bar>2</Bar>'.
             '<Bar>3</Bar>'.
+            '<a><![CDATA[b]]></a>'.
             '</response>'."\n";
         $this->assertEquals($expected, $this->encoder->encode($obj, 'xml'));
     }