[Serializer] AbstractObjectNormalizer improve perf when checking types

symfony · Aug 26, 2018 · 4224145 · 4224145
1 parent ff1727e
commit 4224145
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -37,6 +37,7 @@ abstract class AbstractObjectNormalizer extends AbstractNormalizer
     const DISABLE_TYPE_ENFORCEMENT = 'disable_type_enforcement';
 
     private $propertyTypeExtractor;
+    private $typesCache = array();
     private $attributesCache = array();
 
     /**
@@ -366,24 +367,31 @@ private function getTypes(string $currentClass, string $attribute)
             return null;
         }
 
+        $key = $currentClass.'::'.$attribute;
+        if (isset($this->typesCache[$key])) {
+            return false === $this->typesCache[$key] ? null : $this->typesCache[$key];
+        }
+
         if (null !== $types = $this->propertyTypeExtractor->getTypes($currentClass, $attribute)) {
-            return $types;
+            return $this->typesCache[$key] = $types;
         }
 
         if (null !== $this->classDiscriminatorResolver && null !== $discriminatorMapping = $this->classDiscriminatorResolver->getMappingForClass($currentClass)) {
             if ($discriminatorMapping->getTypeProperty() === $attribute) {
-                return array(
+                return $this->typesCache[$key] = array(
                     new Type(Type::BUILTIN_TYPE_STRING),
                 );
             }
 
             foreach ($discriminatorMapping->getTypesMapping() as $mappedClass) {
                 if (null !== $types = $this->propertyTypeExtractor->getTypes($mappedClass, $attribute)) {
-                    return $types;
+                    return $this->typesCache[$key] = $types;
                 }
             }
         }
 
+        $this->typesCache[$key] = false;
+
         return null;
     }