Skip to content

Commit

Permalink
minor #20164 Uniformize exception vars according to our CS (dunglas)
Browse files Browse the repository at this point in the history
This PR was merged into the 2.8 branch.

Discussion
----------

Uniformize exception vars according to our CS

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

My initial intent was to [fix this typo](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php#L269). But we use `$e` almost everywhere else in this case, so I updated the whole component to be consistent.

Commits
-------

cc9a499 Uniformize exception vars according to our CS
  • Loading branch information
fabpot committed Oct 5, 2016
2 parents ed8ccd1 + cc9a499 commit 42e20f3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Expand Up @@ -208,7 +208,7 @@ private function getDocBlockFromProperty($class, $property)
// Use a ReflectionProperty instead of $class to get the parent class if applicable
try {
$reflectionProperty = new \ReflectionProperty($class, $property);
} catch (\ReflectionException $reflectionException) {
} catch (\ReflectionException $e) {
return;
}

Expand Down Expand Up @@ -260,7 +260,7 @@ private function getDocBlockFromMethod($class, $ucFirstProperty, $type)
) {
break;
}
} catch (\ReflectionException $reflectionException) {
} catch (\ReflectionException $e) {
// Try the next prefix if the method doesn't exist
}
}
Expand Down
Expand Up @@ -51,7 +51,7 @@ public function getProperties($class, array $context = array())
{
try {
$reflectionClass = new \ReflectionClass($class);
} catch (\ReflectionException $reflectionException) {
} catch (\ReflectionException $e) {
return;
}

Expand Down Expand Up @@ -261,7 +261,7 @@ private function isPublicProperty($class, $property)
$reflectionProperty = new \ReflectionProperty($class, $property);

return $reflectionProperty->isPublic();
} catch (\ReflectionException $reflectionExcetion) {
} catch (\ReflectionException $e) {
// Return false if the property doesn't exist
}

Expand Down Expand Up @@ -290,7 +290,7 @@ private function getAccessorMethod($class, $property)
if (0 === $reflectionMethod->getNumberOfRequiredParameters()) {
return array($reflectionMethod, $prefix);
}
} catch (\ReflectionException $reflectionException) {
} catch (\ReflectionException $e) {
// Return null if the property doesn't exist
}
}
Expand Down Expand Up @@ -319,7 +319,7 @@ private function getMutatorMethod($class, $property)
if ($reflectionMethod->getNumberOfParameters() >= 1) {
return array($reflectionMethod, $prefix);
}
} catch (\ReflectionException $reflectionException) {
} catch (\ReflectionException $e) {
// Try the next prefix if the method doesn't exist
}
}
Expand Down

0 comments on commit 42e20f3

Please sign in to comment.