Skip to content

Commit

Permalink
minor #20397 Tweaked the new firewall config in the security profiler…
Browse files Browse the repository at this point in the history
… panel (javiereguiluz)

This PR was merged into the 3.2-dev branch.

Discussion
----------

Tweaked the new firewall config in the security profiler panel

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

All these options can be `null` ... so maybe we should take care of that edge case.

### Before

![before](https://cloud.githubusercontent.com/assets/73419/19962832/cfc1a1ca-a1b9-11e6-852c-4c7e4065eb37.png)

### After

![after](https://cloud.githubusercontent.com/assets/73419/19962835/d2bd113e-a1b9-11e6-92ae-f93d4592473c.png)

Commits
-------

cdbbd9d Tweaked the new firewall config in the security profiler panel
  • Loading branch information
fabpot committed Nov 3, 2016
2 parents 31d5fff + cdbbd9d commit 4459598
Showing 1 changed file with 9 additions and 8 deletions.
Expand Up @@ -145,6 +145,7 @@
<span class="label">Allows anonymous</span>
</div>
</div>

{% if collector.firewall.security_enabled %}
<table>
<thead>
Expand All @@ -156,38 +157,38 @@
<tbody>
<tr>
<th>provider</th>
<td>{{ collector.firewall.provider }}</td>
<td>{{ collector.firewall.provider ?: '(none)' }}</td>
</tr>
<tr>
<th>context</th>
<td>{{ collector.firewall.context }}</td>
<td>{{ collector.firewall.context ?: '(none)' }}</td>
</tr>
<tr>
<th>entry_point</th>
<td>{{ collector.firewall.entry_point }}</td>
<td>{{ collector.firewall.entry_point ?: '(none)' }}</td>
</tr>
<tr>
<th>user_checker</th>
<td>{{ collector.firewall.user_checker }}</td>
<td>{{ collector.firewall.user_checker ?: '(none)' }}</td>
</tr>
<tr>
<th>access_denied_handler</th>
<td>{{ collector.firewall.access_denied_handler }}</td>
<td>{{ collector.firewall.access_denied_handler ?: '(none)' }}</td>
</tr>
<tr>
<th>access_denied_url</th>
<td>{{ collector.firewall.access_denied_url }}</td>
<td>{{ collector.firewall.access_denied_url ?: '(none)' }}</td>
</tr>
<tr>
<th>listeners</th>
<td>{{ collector.firewall.listeners is empty ? 'none' : profiler_dump(collector.firewall.listeners, maxDepth=1) }}</td>
<td>{{ collector.firewall.listeners is empty ? '(none)' : profiler_dump(collector.firewall.listeners, maxDepth=1) }}</td>
</tr>
</tbody>
</table>
{% endif %}
{% elseif collector.enabled %}
<div class="empty">
<p>There is no firewall.</p>
<p>This request was not covered by any firewall.</p>
</div>
{% endif %}
{% else %}
Expand Down

0 comments on commit 4459598

Please sign in to comment.