Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minor #28321 [Routing] Fixed the interface description of the url gen…
…erator interface (Toflar) This PR was merged into the 2.8 branch. Discussion ---------- [Routing] Fixed the interface description of the url generator interface | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The `UrlGenerator` has always been able to return `null`. Many tests assert this for many years but the interface actually always only allowed a `string` return. Examples for tests: - https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L206 - https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L217 - https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L471 So I think I would not consider this change as a BC break but rather a doc fix because it seems like `null` has always been an accepted return value. Commits ------- d2e9e0b Fixed the interface description of the url generator interface
- Loading branch information