[HttpFoundation] implement session locking for PDO

symfony · May 17, 2014 · 50ec828 · 50ec828 · anlutro · May 19, 2014
1 parent 1ad7d05
commit 50ec828
Show file tree

Hide file tree

Showing 3 changed files with 327 additions and 115 deletions.
diff --git a/src/Symfony/Component/HttpFoundation/Resources/stubs/SessionHandlerInterface.php b/src/Symfony/Component/HttpFoundation/Resources/stubs/SessionHandlerInterface.php
@@ -12,13 +12,22 @@
 /**
  * SessionHandlerInterface for PHP < 5.4
  *
+ * The order in which these methods are invoked by PHP are:
+ * 1. open [session_start]
+ * 2. read
+ * 3. gc [optional depending on probability settings: gc_probability / gc_divisor]
+ * 4. destroy [optional when session_regenerate_id(true) is used]
+ * 5. write [session_write_close] or destroy [session_destroy]
+ * 6. close
+ *
  * Extensive documentation can be found at php.net, see links:
  *
  * @see http://php.net/sessionhandlerinterface
  * @see http://php.net/session.customhandler
  * @see http://php.net/session-set-save-handler
  *
  * @author Drak <drak@zikula.org>
+ * @author Tobias Schultze <http://tobion.de>
  */
 interface SessionHandlerInterface
 {
@@ -57,6 +66,9 @@ public function read($sessionId);
     /**
      * Writes the session data to the storage.
      *
+     * Care, the session ID passed to write() can be different from the one previously
+     * received in read() when the session ID changed due to session_regenerate_id().
+     *
      * @see http://php.net/sessionhandlerinterface.write
      *
      * @param string $sessionId Session ID , see http://php.net/function.session-id