Skip to content

Commit

Permalink
minor #23362 [VarDumper] Remove HHVM compat in date caster (maidmaid)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.0-dev branch.

Discussion
----------

[VarDumper] Remove HHVM compat in date caster

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Commits
-------

41fecee Remove hhvm compat
  • Loading branch information
fabpot committed Jul 4, 2017
2 parents b092d1b + 41fecee commit 511ebed
Showing 1 changed file with 0 additions and 4 deletions.
Expand Up @@ -28,10 +28,6 @@ class DateCasterTest extends TestCase
*/
public function testDumpDateTime($time, $timezone, $expected)
{
if ((defined('HHVM_VERSION_ID') || PHP_VERSION_ID <= 50509) && preg_match('/[-+]\d{2}:\d{2}/', $timezone)) {
$this->markTestSkipped('DateTimeZone GMT offsets are supported since 5.5.10. See https://github.com/facebook/hhvm/issues/5875 for HHVM.');
}

$date = new \DateTime($time, new \DateTimeZone($timezone));

$xDump = <<<EODUMP
Expand Down

0 comments on commit 511ebed

Please sign in to comment.