Skip to content

Commit

Permalink
[Validator] Implemented Execute constraint
Browse files Browse the repository at this point in the history
  • Loading branch information
Bernhard Schussek committed Feb 3, 2011
1 parent d8e03ac commit 5ed4d91
Show file tree
Hide file tree
Showing 3 changed files with 211 additions and 0 deletions.
41 changes: 41 additions & 0 deletions src/Symfony/Component/Validator/Constraints/Execute.php
@@ -0,0 +1,41 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien.potencier@symfony-project.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Validator\Constraints;

class Execute extends \Symfony\Component\Validator\Constraint
{
public $methods;

/**
* {@inheritDoc}
*/
public function requiredOptions()
{
return array('methods');
}

/**
* {@inheritDoc}
*/
public function defaultOption()
{
return 'methods';
}

/**
* {@inheritDoc}
*/
public function targets()
{
return self::CLASS_CONSTRAINT;
}
}
56 changes: 56 additions & 0 deletions src/Symfony/Component/Validator/Constraints/ExecuteValidator.php
@@ -0,0 +1,56 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien.potencier@symfony-project.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Validator\Constraints;

use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\Exception\UnexpectedTypeException;

/**
* Validator for Execute constraint
*
* @author Bernhard Schussek <bernhard.schussek@symfony-project.com>
*/
class ExecuteValidator extends ConstraintValidator
{
public function isValid($object, Constraint $constraint)
{
if (null === $object) {
return true;
}

$methods = (array)$constraint->methods;
$context = $this->context;

// save context state
$currentClass = $context->getCurrentClass();
$currentProperty = $context->getCurrentProperty();
$group = $context->getGroup();
$propertyPath = $context->getPropertyPath();

foreach ($methods as $method) {
if (!method_exists($object, $method)) {
throw new ConstraintDefinitionException(sprintf('Method "%s" targeted by Execute constraint does not exist', $method));
}

$object->$method($context);

// restore context state
$context->setCurrentClass($currentClass);
$context->setCurrentProperty($currentProperty);
$context->setGroup($group);
$context->setPropertyPath($propertyPath);
}

return true;
}
}
@@ -0,0 +1,114 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien.potencier@symfony-project.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Tests\Component\Validator;

use Symfony\Component\Validator\ExecutionContext;
use Symfony\Component\Validator\ConstraintViolation;
use Symfony\Component\Validator\ConstraintViolationList;
use Symfony\Component\Validator\Constraints\Execute;
use Symfony\Component\Validator\Constraints\ExecuteValidator;

class ExecuteValidatorTest_Object
{
public function validateOne(ExecutionContext $context)
{
$context->setCurrentClass('Foo');
$context->setCurrentProperty('bar');
$context->setGroup('mygroup');
$context->setPropertyPath('foo.bar');

$context->addViolation('My message', array('parameter'), 'invalidValue');
}

public function validateTwo(ExecutionContext $context)
{
$context->addViolation('Other message', array('other parameter'), 'otherInvalidValue');
}
}

class ExecuteValidatorTest extends \PHPUnit_Framework_TestCase
{
protected $validator;
protected $walker;
protected $context;

protected function setUp()
{
$this->walker = $this->getMock('Symfony\Component\Validator\GraphWalker', array(), array(), '', false);
$metadataFactory = $this->getMock('Symfony\Component\Validator\Mapping\ClassMetadataFactoryInterface');

$this->context = new ExecutionContext('Root', $this->walker, $metadataFactory);
$this->context->setCurrentClass('InitialClass');
$this->context->setCurrentProperty('initialProperty');
$this->context->setGroup('InitialGroup');
$this->context->setPropertyPath('initial.property.path');

$this->validator = new ExecuteValidator();
$this->validator->initialize($this->context);
}

public function testNullIsValid()
{
$this->assertTrue($this->validator->isValid(null, new Execute('foo')));
}

public function testExecuteSingleMethod()
{
$object = new ExecuteValidatorTest_Object();

$this->assertTrue($this->validator->isValid($object, new Execute('validateOne')));

$violations = new ConstraintViolationList();
$violations->add(new ConstraintViolation(
'My message',
array('parameter'),
'Root',
'foo.bar',
'invalidValue'
));

$this->assertEquals($violations, $this->context->getViolations());
$this->assertEquals('InitialClass', $this->context->getCurrentClass());
$this->assertEquals('initialProperty', $this->context->getCurrentProperty());
$this->assertEquals('InitialGroup', $this->context->getGroup());
$this->assertEquals('initial.property.path', $this->context->getPropertyPath());
}

public function testExecuteMultipleMethods()
{
$object = new ExecuteValidatorTest_Object();

$this->assertTrue($this->validator->isValid($object, new Execute(array(
'validateOne', 'validateTwo'
))));

$violations = new ConstraintViolationList();
$violations->add(new ConstraintViolation(
'My message',
array('parameter'),
'Root',
'foo.bar',
'invalidValue'
));

// context was reset
$violations->add(new ConstraintViolation(
'Other message',
array('other parameter'),
'Root',
'initial.property.path',
'otherInvalidValue'
));

$this->assertEquals($violations, $this->context->getViolations());
}
}

0 comments on commit 5ed4d91

Please sign in to comment.