[HttpFoundation] domain shouldn't be required

Spec says: "The default value of domain is the host name of the server which generated the cookie response."
symfony · Jul 24, 2010 · 6142700 · 6142700
1 parent 02fe129
commit 6142700
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/Symfony/Components/HttpFoundation/HeaderBag.php b/src/Symfony/Components/HttpFoundation/HeaderBag.php
@@ -192,10 +192,6 @@ public function setCookie($name, $value, $domain = null, $expires = null, $path
             return $this->set('Cookie', $cookie);
         }
 
-        if (!$domain) {
-            throw new \InvalidArgumentException('The cookie domain cannot be empty');
-        }
-
         if (null !== $expires) {
             if (is_numeric($expires)) {
                 $expires = (int) $expires;
@@ -211,7 +207,9 @@ public function setCookie($name, $value, $domain = null, $expires = null, $path
             $cookie .= '; expires='.substr(\DateTime::createFromFormat('U', $expires, new \DateTimeZone('UTC'))->format('D, d-M-Y H:i:s T'), 0, -5);
         }
 
-        $cookie .= '; domain='.$domain;
+        if ($domain) {
+            $cookie .= '; domain='.$domain;
+        }
 
         if ('/' !== $path) {
             $cookie .= '; path='.$path;