Convert parameter name to lowercase when removing an element from Par…

…ameterBag
symfony · Sep 10, 2012 · 690e28e · 690e28e
1 parent e7059b4
commit 690e28e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php b/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php
@@ -135,7 +135,7 @@ public function has($name)
      */
     public function remove($key)
     {
-        unset($this->parameters[$key]);
+        unset($this->parameters[strtolower($key)]);
     }
 
     /**

diff --git a/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php b/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php
@@ -54,6 +54,8 @@ public function testRemove()
         ));
         $bag->remove('foo');
         $this->assertEquals(array('bar' => 'bar'), $bag->all(), '->remove() removes a parameter');
+        $bag->remove('BAR');
+        $this->assertEquals(array(), $bag->all(), '->remove() converts key to lowercase before removing');
     }
 
     /**