[MonologBridge] Return empty list for unknonwn requests

symfony · Nov 25, 2018 · 69be8e6 · 69be8e6
1 parent b178266
commit 69be8e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/Symfony/Bridge/Monolog/Processor/DebugProcessor.php b/src/Symfony/Bridge/Monolog/Processor/DebugProcessor.php
@@ -60,8 +60,8 @@ public function __invoke(array $record)
      */
     public function getLogs(/* Request $request = null */)
     {
-        if (1 <= \func_num_args() && null !== ($request = \func_get_arg(0)) && isset($this->records[$hash = spl_object_hash($request)])) {
-            return $this->records[$hash];
+        if (1 <= \func_num_args() && null !== $request = \func_get_arg(0)) {
+            return $this->records[spl_object_hash($request)] ?? array();
         }
 
         if (0 === \count($this->records)) {
@@ -76,8 +76,8 @@ public function getLogs(/* Request $request = null */)
      */
     public function countErrors(/* Request $request = null */)
     {
-        if (1 <= \func_num_args() && null !== ($request = \func_get_arg(0)) && isset($this->errorCount[$hash = spl_object_hash($request)])) {
-            return $this->errorCount[$hash];
+        if (1 <= \func_num_args() && null !== $request = \func_get_arg(0)) {
+            return $this->errorCount[spl_object_hash($request)] ?? 0;
         }
 
         return array_sum($this->errorCount);

diff --git a/src/Symfony/Bridge/Monolog/Tests/Processor/DebugProcessorTest.php b/src/Symfony/Bridge/Monolog/Tests/Processor/DebugProcessorTest.php
@@ -58,6 +58,9 @@ public function testWithRequestStack()
 
         $this->assertCount(2, $processor->getLogs($request));
         $this->assertSame(1, $processor->countErrors($request));
+
+        $this->assertCount(0, $processor->getLogs(new Request()));
+        $this->assertSame(0, $processor->countErrors(new Request()));
     }
 
     private function getRecord($level = Logger::WARNING, $message = 'test')