[EventDispatcher] added EventDispatcher::removeSubscriber()

symfony · Mar 18, 2011 · 69d324e · 69d324e
1 parent 10a02ff
commit 69d324e
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/src/Symfony/Component/EventDispatcher/EventDispatcher.php b/src/Symfony/Component/EventDispatcher/EventDispatcher.php
@@ -157,6 +157,14 @@ public function addSubscriber(EventSubscriberInterface $subscriber, $priority =
         $this->addListener($subscriber->getSubscribedEvents(), $subscriber, $priority);
     }
 
+    /**
+     * @see EventDispatcherInterface::removeSubscriber
+     */
+    public function removeSubscriber(EventSubscriberInterface $subscriber)
+    {
+        $this->removeListener($subscriber->getSubscribedEvents(), $subscriber);
+    }
+
     /**
      * Triggers the listener method for an event.
      *

diff --git a/src/Symfony/Component/EventDispatcher/EventDispatcherInterface.php b/src/Symfony/Component/EventDispatcher/EventDispatcherInterface.php
@@ -61,6 +61,13 @@ function addSubscriber(EventSubscriberInterface $subscriber, $priority = 0);
      */
     function removeListener($eventNames, $listener);
 
+    /**
+     * Removes an event subscriber.
+     *
+     * @param EventSubscriberInterface $subscriber The subscriber.
+     */
+    function removeSubscriber(EventSubscriberInterface $subscriber);
+
     /**
      * Gets the listeners of a specific event or all listeners.
      *

diff --git a/tests/Symfony/Tests/Component/EventDispatcher/EventDispatcherTest.php b/tests/Symfony/Tests/Component/EventDispatcher/EventDispatcherTest.php
@@ -168,6 +168,17 @@ public function testAddSubscriber()
         $this->assertTrue($this->dispatcher->hasListeners(self::preFoo));
         $this->assertTrue($this->dispatcher->hasListeners(self::postFoo));
     }
+
+    public function testRemoveSubscriber()
+    {
+        $eventSubscriber = new TestEventSubscriber();
+        $this->dispatcher->addSubscriber($eventSubscriber);
+        $this->assertTrue($this->dispatcher->hasListeners(self::preFoo));
+        $this->assertTrue($this->dispatcher->hasListeners(self::postFoo));
+        $this->dispatcher->removeSubscriber($eventSubscriber);
+        $this->assertFalse($this->dispatcher->hasListeners(self::preFoo));
+        $this->assertFalse($this->dispatcher->hasListeners(self::postFoo));
+    }
 }
 
 class TestEventListener