Skip to content

Commit

Permalink
bug #11625 [FrameworkBundle] resolve parameters before the configs ar…
Browse files Browse the repository at this point in the history
…e processed in the config:debug command (xabbuh)

This PR was merged into the 2.5 branch.

Discussion
----------

[FrameworkBundle] resolve parameters before the configs are processed in the config:debug command

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11622
| License       | MIT
| Doc PR        |

If the raw values are passed to the processor, config values don't necessarily have the expected data type. For example, the value of the kernel.debug parameter is a boolean type. But when passed as the raw parameter name, it is a string.

@lyrixx Do you have any objections?

Commits
-------

19f3b47 resolve parameters before the configs are processed
  • Loading branch information
fabpot committed Aug 11, 2014
2 parents 2cf1205 + 19f3b47 commit 7283483
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -75,11 +75,11 @@ protected function execute(InputInterface $input, OutputInterface $output)

$this->validateConfiguration($extension, $configuration);

$configs = $container->getParameterBag()->resolveValue($configs);

$processor = new Processor();
$config = $processor->processConfiguration($configuration, $configs);

$config = $container->getParameterBag()->resolveValue($config);

if ($name === $extension->getAlias()) {
$output->writeln(sprintf('# Current configuration for extension with alias: "%s"', $name));
} else {
Expand Down

0 comments on commit 7283483

Please sign in to comment.