re-organized the sub-request management a bit (WIP)

symfony · May 13, 2010 · 72947d8 · 72947d8
1 parent fd331ba
commit 72947d8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 14 deletions.
diff --git a/src/Symfony/Foundation/Kernel.php b/src/Symfony/Foundation/Kernel.php
@@ -161,7 +161,7 @@ public function getRequest()
     }
 
     /**
-     * Handles a request to convert it to a response by calling the Request Handler service.
+     * Handles a request to convert it to a response by calling the HttpKernel service.
      *
      * @param  Request $request A Request instance
      * @param  Boolean $main    Whether this is the main request or not
@@ -177,15 +177,19 @@ public function handle(Request $request = null, $main = true, $raw = false)
 
         if (null === $request) {
             $request = $this->container->getRequestService();
-        } else {
-            $this->container->setService('request', $request);
         }
 
         if (true === $main) {
             $this->request = $request;
         }
 
-        return $this->container->getHttpKernelService()->handle($request, $main, $raw);
+        $this->container->setService('request', $request);
+
+        $response = $this->container->getHttpKernelService()->handle($request, $main, $raw);
+
+        $this->container->setService('request', $this->request);
+
+        return $response;
     }
 
     public function getBundleDirs()

diff --git a/src/Symfony/Framework/WebBundle/Controller.php b/src/Symfony/Framework/WebBundle/Controller.php
@@ -82,9 +82,9 @@ public function generateUrl($route, array $parameters = array(), $absolute = fal
         return $this->container->getRouterService()->generate($route, $parameters);
     }
 
-    public function forward($controller, array $parameters = array())
+    public function forward($controller, array $path = array(), array $query = array())
     {
-        return $this->container->getControllerLoaderService()->run($controller, $parameters);
+        return $this->container->getControllerLoaderService()->run($controller, $path, $query);
     }
 
     /**

diff --git a/src/Symfony/Framework/WebBundle/Listener/ControllerLoader.php b/src/Symfony/Framework/WebBundle/Listener/ControllerLoader.php
@@ -41,17 +41,11 @@ public function register()
 
     public function run($controller, array $path = array(), array $query = array())
     {
-        $request = $this->container->getRequestService();
-
         $path['_controller'] = $controller;
 
-        $subRequest = $request->duplicate($query, null, $path);
-
-        $response = $this->container->getKernelService()->handle($subRequest, false, true);
-
-        $this->container->setService('request', $request);
+        $subRequest = $this->container->getRequestService()->duplicate($query, null, $path);
 
-        return $response;
+        return $this->container->getKernelService()->handle($subRequest, false, true);
     }
 
     public function resolve(Event $event)