[HttpKernel] removed Response content when Request method is HEAD as …

…per RFC2616
symfony · Jun 4, 2011 · 7780c4d · 7780c4d
1 parent c62b230
commit 7780c4d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/Symfony/Component/HttpKernel/EventListener/ResponseListener.php b/src/Symfony/Component/HttpKernel/EventListener/ResponseListener.php
@@ -36,12 +36,17 @@ public function __construct($charset)
      */
     public function onCoreResponse(FilterResponseEvent $event)
     {
+        $request = $event->getRequest();
+        $response = $event->getResponse();
+
+        if ('HEAD' === $request->getMethod()) {
+            $response->setContent('');
+        }
+
         if (HttpKernelInterface::MASTER_REQUEST !== $event->getRequestType()) {
             return;
         }
 
-        $response = $event->getResponse();
-
         if (null === $response->getCharset()) {
             $response->setCharset($this->charset);
         }
@@ -50,7 +55,6 @@ public function onCoreResponse(FilterResponseEvent $event)
             return;
         }
 
-        $request = $event->getRequest();
         $format = $request->getRequestFormat();
         if ((null !== $format) && $mimeType = $request->getMimeType($format)) {
             $response->headers->set('Content-Type', $mimeType);

diff --git a/tests/Symfony/Tests/Component/HttpKernel/EventListener/ResponseListenerTest.php b/tests/Symfony/Tests/Component/HttpKernel/EventListener/ResponseListenerTest.php
@@ -76,4 +76,15 @@ public function testFilterSetContentType()
 
         $this->assertEquals('application/json', $event->getResponse()->headers->get('content-type'));
     }
+
+    public function testFilterRemovesContentForHeadRequests()
+    {
+        $response = new Response('foo');
+        $request = Request::create('/', 'HEAD');
+
+        $event = new FilterResponseEvent($this->kernel, $request, HttpKernelInterface::MASTER_REQUEST, $response);
+        $this->dispatcher->dispatch(CoreEvents::RESPONSE, $event);
+
+        $this->assertEquals('', $response->getContent());
+    }
 }