Skip to content

Commit

Permalink
bug #32210 [Mailer] Fix timeout type hint (fabpot)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.3 branch.

Discussion
----------

[Mailer] Fix timeout type hint

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The timeout on a socket is a float, not an integer.

Commits
-------

0e7ed9e [Mailer] fixed timeout type hint
  • Loading branch information
fabpot committed Jun 27, 2019
2 parents e55978a + 0e7ed9e commit 791a212
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -34,14 +34,14 @@ final class SocketStream extends AbstractStream
private $sourceIp;
private $streamContextOptions = [];

public function setTimeout(int $timeout): self
public function setTimeout(float $timeout): self
{
$this->timeout = $timeout;

return $this;
}

public function getTimeout(): int
public function getTimeout(): float
{
return $this->timeout;
}
Expand Down

0 comments on commit 791a212

Please sign in to comment.