Skip to content

Commit

Permalink
minor #20884 [Finder] Deprecate ExceptionInterface (ogizanagi)
Browse files Browse the repository at this point in the history
This PR was merged into the 3.3-dev branch.

Discussion
----------

[Finder] Deprecate ExceptionInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

This interface was missed in #15805, and should have been removed in 3.0.

Ideally, the component should have such an interface, though, as other components does. But the only domain exception in this component is an `AccessDeniedException` used by the `RecursiveDirectoryIterator`. So it isn't worth it right now.

I think this interface was almost internal actually, but anyway the `\Symfony\Component\Finder\Adapter\AdapterInterface` interface does not exist anymore. So the `ExceptionInterface::getAdapter()` signature cannot be satisfied anyway. I guess anyone relying on this interface in any way should have notice that and removed anything related to Symfony Finder's adapters when upgrading to 3.0.
Should we consider removing it directly in the 3.1 branch instead?

Commits
-------

1b600b0 [Finder] Deprecate ExceptionInterface
  • Loading branch information
fabpot committed Dec 13, 2016
2 parents 51d13cc + 1b600b0 commit 795a240
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
5 changes: 5 additions & 0 deletions UPGRADE-3.3.md
Expand Up @@ -7,6 +7,11 @@ ClassLoader
* The ApcClassLoader, WinCacheClassLoader and XcacheClassLoader classes have been deprecated
in favor of the `--apcu-autoloader` option introduced in composer 1.3

Finder
------

* The `ExceptionInterface` has been deprecated and will be removed in 4.0.

Security
--------

Expand Down
5 changes: 5 additions & 0 deletions UPGRADE-4.0.md
Expand Up @@ -43,6 +43,11 @@ ExpressionLanguage
class has been removed. You should use the `CacheItemPoolInterface` interface
instead.

Finder
------

* The `ExceptionInterface` has been removed.

Form
----

Expand Down
2 changes: 2 additions & 0 deletions src/Symfony/Component/Finder/Exception/ExceptionInterface.php
Expand Up @@ -13,6 +13,8 @@

/**
* @author Jean-François Simon <contact@jfsimon.fr>
*
* @deprecated since 3.3, to be removed in 4.0.
*/
interface ExceptionInterface
{
Expand Down

0 comments on commit 795a240

Please sign in to comment.