[Form] DateTimeToRfc3339Transformer use proper transformation extepti…

…on in reverse transformation
symfony · Apr 9, 2013 · 7fc429f · 7fc429f
1 parent c8bd45b
commit 7fc429f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToRfc3339Transformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToRfc3339Transformer.php
@@ -53,7 +53,11 @@ public function reverseTransform($rfc3339)
             return null;
         }
 
-        $dateTime = new \DateTime($rfc3339);
+        try {
+            $dateTime = new \DateTime($rfc3339);
+        } catch (\Exception $e) {
+            throw new TransformationFailedException($e->getMessage(), $e->getCode(), $e);
+        }
 
         if ($this->outputTimezone !== $this->inputTimezone) {
             try {

diff --git a/.../Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php b/.../Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php
@@ -119,4 +119,14 @@ public function testReverseTransformWithNonExistingDate()
 
         $transformer->reverseTransform('2010-04-31T04:05Z');
     }
+
+    /**
+     * @expectedException Symfony\Component\Form\Exception\TransformationFailedException
+     */
+    public function testReverseTransformExpectsValidDateString()
+    {        
+        $transformer = new DateTimeToRfc3339Transformer('UTC', 'UTC');
+
+        $transformer->reverseTransform('2010-2010-2010');
+    }
 }