Skip to content

Commit

Permalink
minor #20622 [WebProfilerBundle] Dont use request attributes in Route…
Browse files Browse the repository at this point in the history
…rController (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[WebProfilerBundle] Dont use request attributes in RouterController

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As spotted in #20621, it makes little sense to use request attributes here, and if it were to have, the current code is broken because the returned values here have already been processed by ValueExporter in RequestDataCollector.

Commits
-------

962325a [WebProfilerBundle] Dont use request attributes in RouterController
  • Loading branch information
nicolas-grekas committed Nov 25, 2016
2 parents bbddeec + 962325a commit 821e7bb
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -87,7 +87,7 @@ private function getTraces(RequestDataCollector $request, $method)
$traceRequest = Request::create(
$request->getPathInfo(),
$request->getRequestServer()->get('REQUEST_METHOD'),
$request->getRequestAttributes()->all(),
array(),
$request->getRequestCookies()->all(),
array(),
$request->getRequestServer()->all()
Expand Down

0 comments on commit 821e7bb

Please sign in to comment.