Skip to content

Commit

Permalink
feature #28551 [VarDumper] add caster for MessageFormatter (nicolas-g…
Browse files Browse the repository at this point in the history
…rekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[VarDumper] add caster for MessageFormatter

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

There are more classes in intl that could benefit from having a caster, see
http://php.net/manual/en/book.intl.php

Let's start with MessageFormatter.
PRs welcome for adding more.

Commits
-------

aa24e4c [VarDumper] add caster for MessageFormatter
  • Loading branch information
fabpot committed Sep 22, 2018
2 parents c51592c + aa24e4c commit 85d335a
Show file tree
Hide file tree
Showing 3 changed files with 75 additions and 0 deletions.
37 changes: 37 additions & 0 deletions src/Symfony/Component/VarDumper/Caster/IntlCaster.php
@@ -0,0 +1,37 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\VarDumper\Caster;

use Symfony\Component\VarDumper\Cloner\Stub;

/**
* @author Nicolas Grekas <p@tchwork.com>
*/
class IntlCaster
{
public static function castMessageFormatter(\MessageFormatter $c, array $a, Stub $stub, $isNested)
{
$a += array(
Caster::PREFIX_VIRTUAL.'locale' => $c->getLocale(),
Caster::PREFIX_VIRTUAL.'pattern' => $c->getPattern(),
);

if ($errorCode = $c->getErrorCode()) {
$a += array(
Caster::PREFIX_VIRTUAL.'error_code' => $errorCode,
Caster::PREFIX_VIRTUAL.'error_message' => $c->getErrorMessage(),
);
}

return $a;
}
}
2 changes: 2 additions & 0 deletions src/Symfony/Component/VarDumper/Cloner/AbstractCloner.php
Expand Up @@ -117,6 +117,8 @@ abstract class AbstractCloner implements ClonerInterface

'GMP' => array('Symfony\Component\VarDumper\Caster\GmpCaster', 'castGmp'),

'MessageFormatter' => array('Symfony\Component\VarDumper\Caster\IntlCaster', 'castMessageFormatter'),

':curl' => array('Symfony\Component\VarDumper\Caster\ResourceCaster', 'castCurl'),
':dba' => array('Symfony\Component\VarDumper\Caster\ResourceCaster', 'castDba'),
':dba persistent' => array('Symfony\Component\VarDumper\Caster\ResourceCaster', 'castDba'),
Expand Down
36 changes: 36 additions & 0 deletions src/Symfony/Component/VarDumper/Tests/Caster/IntlCasterTest.php
@@ -0,0 +1,36 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\VarDumper\Tests\Caster;

use PHPUnit\Framework\TestCase;
use Symfony\Component\VarDumper\Test\VarDumperTestTrait;

/**
* @requires extension intl
*/
class IntlCasterTest extends TestCase
{
use VarDumperTestTrait;

public function testArrayIterator()
{
$var = new \MessageFormatter('en', 'Hello {name}');

$expected = <<<EOTXT
MessageFormatter {
locale: "en"
pattern: "Hello {name}"
}
EOTXT;
$this->assertDumpEquals($expected, $var);
}
}

0 comments on commit 85d335a

Please sign in to comment.