Skip to content

Commit

Permalink
bug #25337 Remove Exclusive Lock That Breaks NFS Caching (brianfreytag)
Browse files Browse the repository at this point in the history
This PR was merged into the 3.4 branch.

Discussion
----------

Remove Exclusive Lock That Breaks NFS Caching

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25336
| License       | MIT
| Doc PR        | n/a

#24960 introduced an issue with NFS mounts that do not support exclusive locks. This reverts that change.

FYI @kalessil

Commits
-------

a7ac100 Remove LOCK_EX That Breaks Cache Usage on NFS
  • Loading branch information
nicolas-grekas committed Dec 6, 2017
2 parents 22a6a7e + a7ac100 commit 931fe35
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpKernel/Kernel.php
Expand Up @@ -423,7 +423,7 @@ public function setClassCache(array $classes)
*/
public function setAnnotatedClassCache(array $annotatedClasses)
{
file_put_contents(($this->warmupDir ?: $this->getCacheDir()).'/annotations.map', sprintf('<?php return %s;', var_export($annotatedClasses, true)), LOCK_EX);
file_put_contents(($this->warmupDir ?: $this->getCacheDir()).'/annotations.map', sprintf('<?php return %s;', var_export($annotatedClasses, true)));
}

/**
Expand Down

0 comments on commit 931fe35

Please sign in to comment.