Skip to content

Commit

Permalink
bug #35538 [FrameworkBundle] fixed suggesting deprecated WebServerBun…
Browse files Browse the repository at this point in the history
…dle (jrushlow)

This PR was squashed before being merged into the 5.1-dev branch (closes #35538).

Discussion
----------

[FrameworkBundle] fixed suggesting deprecated WebServerBundle

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35495
| License       | MIT
| Doc PR        |

Removed suggestion to install `symfony/web-server-bundle` in console missing packages suggestions. The web server bundle was deprecated and no longer works with Symfony 5.x, .

Commits
-------

134129b [FrameworkBundle] fixed suggesting deprecated WebServerBundle
  • Loading branch information
fabpot committed Jan 31, 2020
2 parents 9b0a75c + 134129b commit 9d7e622
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Expand Up @@ -39,8 +39,7 @@ final class SuggestMissingPackageSubscriber implements EventSubscriberInterface
'_default' => ['MakerBundle', 'symfony/maker-bundle --dev'],
],
'server' => [
'dump' => ['Debug Bundle', 'symfony/debug-bundle --dev'],
'_default' => ['WebServerBundle', 'symfony/web-server-bundle --dev'],
'_default' => ['Debug Bundle', 'symfony/debug-bundle --dev'],
],
];

Expand Down
Expand Up @@ -208,7 +208,7 @@ public function testRunOnlyWarnsOnUnregistrableCommandAtTheEnd()

public function testSuggestingPackagesWithExactMatch()
{
$result = $this->createEventForSuggestingPackages('server:dump', []);
$result = $this->createEventForSuggestingPackages('doctrine:fixtures', []);
$this->assertRegExp('/You may be looking for a command provided by/', $result);
}

Expand Down

0 comments on commit 9d7e622

Please sign in to comment.