Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug#9154 Fix problem with Windows file links (backslash in JavaScript…
… string) (fabpot) This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9154). Discussion ---------- Fix problem with Windows file links (backslash in JavaScript string) This PR was submitted on the symfony/WebProfilerBundle read-only repository and moved automatically to the main Symfony repository (closes symfony/web-profiler-bundle#5). When you have set php.ini setting xdebug.file_link_format, under Windows this window.location call here isn't escaped properly, so it results in something like: ```HTML <span class="sf-toolbar-info-method" onclick="window.location='pstorm://open/?url=file://F:\HtDocs\myproject\src\Foo\Core\Controller\PageController.php&line=28';window.event.stopPropagation();return false;"> pageAction </span> ``` All backslashes in window.location are treated as escape sequences witch result in an incorrect link: pstorm://open/?url=file://F:HtDocsmyprojectsrcFooCoreControllerPageController.php&line=28 So clicking this link my IDE (phpStorm) couldn't find that file. The patch fixes this by escaping the backslashes. Commits ------- 03c6027 Fix problem with Windows file links (backslash in JavaScript string)
- Loading branch information