Skip to content

Commit

Permalink
minor #26862 [Messenger] Rename the middleware tag (sroze)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Messenger] Rename the middleware tag

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ø
| License       | MIT
| Doc PR        | symfony/symfony-docs#9437

After a using it for a bit of time, it's weird to have the `messenger.message_handler` tag while using the `message_bus_middleware` tag for the middlewares.

I propose to rename the tag from `message_bus_middleware` to `messenger.bus_middleware` to keep some consistency.

Commits
-------

dd18445 Rename the middleware tag from `message_bus_middleware` to `messenger.bus_middleware`
  • Loading branch information
sroze committed Apr 9, 2018
2 parents 5736321 + dd18445 commit a726f05
Showing 1 changed file with 6 additions and 6 deletions.
Expand Up @@ -9,7 +9,7 @@

<!-- Bus -->
<service id="message_bus" class="Symfony\Component\Messenger\MessageBus" public="true">
<argument type="tagged" tag="message_bus_middleware" /> <!-- Middlewares -->
<argument type="tagged" tag="messenger.bus_middleware" /> <!-- Middlewares -->
</service>

<service id="Symfony\Component\Messenger\MessageBusInterface" alias="message_bus" />
Expand All @@ -22,13 +22,13 @@
<service id="messenger.middleware.call_message_handler" class="Symfony\Component\Messenger\Middleware\HandleMessageMiddleware">
<argument type="service" id="messenger.handler_resolver" />

<tag name="message_bus_middleware" priority="-10" />
<tag name="messenger.bus_middleware" priority="-10" />
</service>

<service id="messenger.middleware.validator" class="Symfony\Component\Messenger\Middleware\ValidationMiddleware">
<argument type="service" id="validator" />

<tag name="message_bus_middleware" priority="100" />
<tag name="messenger.bus_middleware" priority="100" />
</service>

<!-- Asynchronous -->
Expand All @@ -39,7 +39,7 @@
<service id="messenger.asynchronous.middleware.send_message_to_producer" class="Symfony\Component\Messenger\Asynchronous\Middleware\SendMessageMiddleware">
<argument type="service" id="messenger.asynchronous.routing.sender_locator" />

<tag name="message_bus_middleware" priority="-5" />
<tag name="messenger.bus_middleware" priority="-5" />
</service>

<!-- Message encoding/decoding -->
Expand All @@ -54,13 +54,13 @@
<service id="messenger.middleware.debug.logging" class="Symfony\Component\Messenger\Debug\LoggingMiddleware">
<argument type="service" id="logger" />

<tag name="message_bus_middleware" priority="10" />
<tag name="messenger.bus_middleware" priority="10" />
<tag name="monolog.logger" channel="messenger" />
</service>

<service id="data_collector.messenger" class="Symfony\Component\Messenger\DataCollector\MessengerDataCollector">
<tag name="data_collector" template="@WebProfiler/Collector/messenger.html.twig" id="messenger" priority="100" />
<tag name="message_bus_middleware" />
<tag name="messenger.bus_middleware" />
</service>

<!-- Discovery -->
Expand Down

0 comments on commit a726f05

Please sign in to comment.