[HttpKernel] fixed scope management in HttpKernel

We should always leave the request scope at the end of the request processing. If not, the HttpKernel leaves the container in a different state.
symfony · Jan 23, 2011 · b577ce6 · b577ce6
1 parent 86b357d
commit b577ce6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 34 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/HttpKernel.php b/src/Symfony/Bundle/FrameworkBundle/HttpKernel.php
@@ -32,18 +32,14 @@ public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQ
 
         try {
             $response = parent::handle($request, $type, $catch);
-
-            if (HttpKernelInterface::MASTER_REQUEST !== $type) {
-                $this->container->leaveScope('request');
-            }
-
-            return $response;
         } catch (\Exception $e) {
-            if (HttpKernelInterface::MASTER_REQUEST !== $type) {
-                $this->container->leaveScope('request');
-            }
+            $this->container->leaveScope('request');
 
             throw $e;
         }
+
+        $this->container->leaveScope('request');
+
+        return $response;
     }
-}
+}
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/HttpKernelTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/HttpKernelTest.php
@@ -25,18 +25,11 @@ public function testHandle($type)
             ->method('enterScope')
             ->with($this->equalTo('request'))
         ;
-        if ($type !== HttpKernelInterface::MASTER_REQUEST) {
-            $container
-                ->expects($this->once())
-                ->method('leaveScope')
-                ->with($this->equalTo('request'))
-            ;
-        } else {
-            $container
-                ->expects($this->never())
-                ->method('leaveScope')
-            ;
-        }
+        $container
+            ->expects($this->once())
+            ->method('leaveScope')
+            ->with($this->equalTo('request'))
+        ;
         $container
             ->expects($this->once())
             ->method('set')
@@ -80,18 +73,11 @@ public function testHandleRestoresThePreviousRequestOnException($type)
             ->method('enterScope')
             ->with($this->equalTo('request'))
         ;
-        if ($type !== HttpKernelInterface::MASTER_REQUEST) {
-            $container
-                ->expects($this->once())
-                ->method('leaveScope')
-                ->with($this->equalTo('request'))
-            ;
-        } else {
-            $container
-                ->expects($this->never())
-                ->method('leaveScope')
-            ;
-        }
+        $container
+            ->expects($this->once())
+            ->method('leaveScope')
+            ->with($this->equalTo('request'))
+        ;
         $container
             ->expects($this->once())
             ->method('set')