Skip to content

Commit

Permalink
feature #23402 [Ldap] Remove the RenameEntryInterface interface (maid…
Browse files Browse the repository at this point in the history
…maid)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[Ldap] Remove the RenameEntryInterface interface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20390
| License       | MIT
| Doc PR        | /

Commits
-------

5d35184 Remove the RenameEntryInterface interface
  • Loading branch information
fabpot committed Jul 6, 2017
2 parents 6aa6644 + 5d35184 commit b9d93c8
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 24 deletions.
10 changes: 10 additions & 0 deletions src/Symfony/Component/Ldap/Adapter/EntryManagerInterface.php
Expand Up @@ -20,6 +20,7 @@
*
* @author Charles Sarrazin <charles@sarraz.in>
* @author Bob van de Vijver <bobvandevijver@hotmail.com>
* @author Kevin Schuurmans <kevin.schuurmans@freshheads.com>
*/
interface EntryManagerInterface
{
Expand All @@ -43,6 +44,15 @@ public function add(Entry $entry);
*/
public function update(Entry $entry);

/**
* Renames an entry on the Ldap server.
*
* @param Entry $entry
* @param string $newRdn
* @param bool $removeOldRdn
*/
public function rename(Entry $entry, $newRdn, $removeOldRdn = true);

/**
* Removes an entry from the Ldap server.
*
Expand Down
3 changes: 1 addition & 2 deletions src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Component\Ldap\Adapter\ExtLdap;

use Symfony\Component\Ldap\Adapter\EntryManagerInterface;
use Symfony\Component\Ldap\Adapter\RenameEntryInterface;
use Symfony\Component\Ldap\Entry;
use Symfony\Component\Ldap\Exception\LdapException;
use Symfony\Component\Ldap\Exception\NotBoundException;
Expand All @@ -21,7 +20,7 @@
* @author Charles Sarrazin <charles@sarraz.in>
* @author Bob van de Vijver <bobvandevijver@hotmail.com>
*/
class EntryManager implements EntryManagerInterface, RenameEntryInterface
class EntryManager implements EntryManagerInterface
{
private $connection;

Expand Down
22 changes: 0 additions & 22 deletions src/Symfony/Component/Ldap/Adapter/RenameEntryInterface.php

This file was deleted.

1 change: 1 addition & 0 deletions src/Symfony/Component/Ldap/CHANGELOG.md
Expand Up @@ -5,6 +5,7 @@ CHANGELOG
-----

* removed the `LdapClient` class and the `LdapClientInterface`
* removed the `RenameEntryInterface` interface and merged with `EntryManagerInterface`

3.1.0
-----
Expand Down

0 comments on commit b9d93c8

Please sign in to comment.