Skip to content

Commit

Permalink
minor #36546 [Mailer] Add a comment to avoid more wrong PRs on this p…
Browse files Browse the repository at this point in the history
…iece of code (fabpot)

This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Add a comment to avoid more wrong PRs on this piece of code

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Numerous bogus PRs <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

444e616 [Mailer] Add a comment to avoid more wrong PRs on this piece of code
  • Loading branch information
fabpot committed Apr 23, 2020
2 parents 119ba3b + 444e616 commit bbbf80f
Showing 1 changed file with 3 additions and 0 deletions.
Expand Up @@ -106,6 +106,9 @@ protected function doHeloCommand(): void

/** @var SocketStream $stream */
$stream = $this->getStream();
// WARNING: !$stream->isTLS() is right, 100% sure :)
// if you think that the ! should be removed, read the code again
// if doing so "fixes" your issue then it probably means your SMTP server behaves incorrectly or is wrongly configured
if (!$stream->isTLS() && \defined('OPENSSL_VERSION_NUMBER') && \array_key_exists('STARTTLS', $capabilities)) {
$this->executeCommand("STARTTLS\r\n", [220]);

Expand Down

0 comments on commit bbbf80f

Please sign in to comment.