minor #33790 [Console] remove abbreviation support for hidden command…

…s (xabbuh) This PR was merged into the 5.0-dev branch. Discussion ---------- [Console] remove abbreviation support for hidden commands | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 6623ec2 remove abbreviation support for hidden commands
symfony · Oct 1, 2019 · c75098e · c75098e
2 parents 5e48c39 + 6623ec2
commit c75098e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 25 deletions.
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -693,7 +693,7 @@ public function find(string $name)
         $command = $this->get(reset($commands));
 
         if ($command->isHidden()) {
-            @trigger_error(sprintf('Command "%s" is hidden, finding it using an abbreviation is deprecated since Symfony 4.4, use its full name instead.', $command->getName()), E_USER_DEPRECATED);
+            throw new CommandNotFoundException(sprintf('The command "%s" does not exist.', $name));
         }
 
         return $command;

diff --git a/src/Symfony/Component/Console/CHANGELOG.md b/src/Symfony/Component/Console/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 5.0.0
 -----
 
+ * removed support for finding hidden commands using an abbreviation, use the full name instead
  * removed `TableStyle::setCrossingChar()` method in favor of `TableStyle::setDefaultCrossingChar()`
  * removed `TableStyle::setHorizontalBorderChar()` method in favor of `TableStyle::setDefaultCrossingChars()`
  * removed `TableStyle::getHorizontalBorderChar()` method in favor of `TableStyle::getBorderChars()`

diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -728,30 +728,6 @@ public function testFindHiddenWithExactName()
         $this->assertInstanceOf('FooHiddenCommand', $application->find('afoohidden'));
     }
 
-    /**
-     * @group legacy
-     * @expectedDeprecation Command "%s:hidden" is hidden, finding it using an abbreviation is deprecated since Symfony 4.4, use its full name instead.
-     * @dataProvider provideAbbreviationsForHiddenCommands
-     */
-    public function testFindHiddenWithAbbreviatedName($name)
-    {
-        $application = new Application();
-
-        $application->add(new \FooHiddenCommand());
-        $application->add(new \BarHiddenCommand());
-
-        $application->find($name);
-    }
-
-    public function provideAbbreviationsForHiddenCommands()
-    {
-        return [
-            ['foo:hidde'],
-            ['afoohidd'],
-            ['bar:hidde'],
-        ];
-    }
-
     public function testFindAmbiguousCommandsIfAllAlternativesAreHidden()
     {
         $application = new Application();